nssalian commented on code in PR #2188:
URL: https://github.com/apache/iceberg-rust/pull/2188#discussion_r3326792932
##########
crates/catalog/hms/src/schema.rs:
##########
@@ -139,6 +139,10 @@ impl SchemaVisitor for HiveSchemaBuilder {
Ok(hive_type)
}
+
+ fn variant(&mut self, _v: &iceberg::spec::VariantType) -> Result<Self::T> {
Review Comment:
I would lean towards matching with Java. "unknown" is what the
metastore-facing type string should be here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
