blackmwk commented on PR #2467: URL: https://github.com/apache/iceberg-rust/pull/2467#issuecomment-4581485654
> The strongest example is span propagation across spawn boundaries. When you tokio::spawn, the tracing span context is severed, the spawned task doesn't inherit the parent span. So if you're tracing a table scan that spawns 50 IO tasks to fetch manifests and data files, those tasks appear as orphans in your Jaeger/Tempo traces rather than children of the scan. > > Very similar conversation was had when this was introduced in datafusion [apache/datafusion#14547](https://github.com/apache/datafusion/pull/14547) After a second thought, I'm still hesitating to add such a feature into core library before we actually see a solid use case. I guess datafusion accepts this because it's much more extensible than `iceberg` library? Even if in some use cases where user may provide their own implementation such as `Catalog`, `Storage`, what's the problem of adding `#[tracing::instrument]` attribute to the function they want to trace? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
