geoffreyclaude commented on PR #2467: URL: https://github.com/apache/iceberg-rust/pull/2467#issuecomment-4669010019
I ran into this same need while looking at DataFusion + Iceberg tracing together. Thanks for working on this, it looks like a very useful direction to me. The useful bit for me is context propagation across Iceberg-owned spawn boundaries: once an application gives Iceberg a `Runtime`, later work spawned through `runtime.io()` / `runtime.cpu()` is hard to wrap from the outside. This PR’s runtime-local hook would give callers a clean place to propagate spans / OTel context / metrics scopes without Iceberg depending on any specific observability stack. This is very similar to the problem we solved with `JoinSetTracer` in [apache/datafusion#14547](https://github.com/apache/datafusion/pull/14547), following the broader tracing discussion in [apache/datafusion#9415](https://github.com/apache/datafusion/issues/9415). For context, we later added a small regression test around this in [apache/datafusion#15673](https://github.com/apache/datafusion/pull/15673): it uses an asserting tracer plus a traceable object store to prove spawned work can still be linked back to the root query task. I don’t think Iceberg needs to copy that exact test shape here, but it’s a useful example of the kind of integration this hook enables. This would also fit nicely with projects like [`datafusion-contrib/datafusion-tracing`](https://github.com/datafusion-contrib/datafusion-tracing), where tracing DataFusion and Iceberg together needs the same kind of spawn-boundary context propagation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
