lishuxu commented on code in PR #646:
URL: https://github.com/apache/iceberg-cpp/pull/646#discussion_r3328853503
##########
src/iceberg/catalog/rest/auth/auth_manager.cc:
##########
@@ -130,7 +130,8 @@ class OAuth2Manager : public AuthManager {
init_token_response_.reset();
return AuthSession::MakeOAuth2(token_response,
config.oauth2_server_uri(),
config.client_id(),
config.client_secret(),
- config.scope(), client);
+ config.scope(), config.keep_refreshed(),
+ config.optional_oauth_params(), client);
}
// If token is provided, use it directly.
Review Comment:
Agreed. This is tightly coupled to the token-exchange work (a configured
token has no credential, so Java refreshes it via exchange), so I'll bundle it
into the same follow-up PR: add token-expires-in-ms, populate
expires_at_millis_, and wrap configured tokens in a refreshable session. Will
link the PR here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
