lishuxu commented on code in PR #646:
URL: https://github.com/apache/iceberg-cpp/pull/646#discussion_r3328854012


##########
src/iceberg/util/transform_util.h:
##########
@@ -139,6 +140,19 @@ class ICEBERG_EXPORT TransformUtil {
 
   /// \brief Base64 encode a string
   static std::string Base64Encode(std::string_view str_to_encode);
+
+  /// \brief Base64 decode a string (standard alphabet: +/).
+  ///
+  /// Handles optional padding ('=').
+  /// \return Decoded string, or an error if the input contains invalid 
characters.
+  static Result<std::string> Base64Decode(std::string_view encoded);

Review Comment:
   Done. Moved the Base64* functions into a new base64.h/base64.cc (Base64 
class), and migrated the tests to base64_test.cc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to