Guosmilesmile commented on code in PR #16575: URL: https://github.com/apache/iceberg/pull/16575#discussion_r3328958590
########## data/src/test/java/org/apache/iceberg/data/FileFormatTestSupport.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.data; + +import java.io.IOException; +import java.util.Arrays; +import java.util.List; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.Schema; +import org.apache.iceberg.data.avro.AvroFormat; +import org.apache.iceberg.data.orc.OrcFormat; +import org.apache.iceberg.data.parquet.ParquetFormat; +import org.apache.iceberg.io.InputFile; +import org.apache.iceberg.io.OutputFile; + +public interface FileFormatTestSupport { + + String FEATURE_FILTER = "filter"; + String FEATURE_CASE_SENSITIVE = "caseSensitive"; + String FEATURE_SPLIT = "split"; + String FEATURE_READER_DEFAULT = "readerDefault"; + String FEATURE_REUSE_CONTAINERS = "reuseContainers"; + String FEATURE_COLUMN_LEVEL_METRICS = "columnLevelMetrics"; + String FEATURE_COLUMN_METRICS_TRUNCATE_BINARY = "columnMetricsTruncateBinary"; + + FileFormatTestSupport[] ALL = + new FileFormatTestSupport[] {new AvroFormat(), new OrcFormat(), new ParquetFormat()}; + + static FileFormat[] formats() { + return Arrays.stream(ALL).map(FileFormatTestSupport::format).toArray(FileFormat[]::new); + } + + static FileFormatTestSupport forFormat(FileFormat format) { + return Arrays.stream(ALL) + .filter(testSupportFormat -> testSupportFormat.format() == format) + .findFirst() + .orElseThrow(() -> new UnsupportedOperationException("Unsupported file format: " + format)); + } + + FileFormat format(); + + default boolean supportsFeature(String feature) { + return true; + } + + void writeRecordsWithoutFieldIds(OutputFile outputFile, Schema schema, List<Record> records) + throws IOException; + + String compressionProperty(); + + String compressionValue(); + + String expectedCompressionCodec(); + + String actualCompressionCodec(InputFile inputFile) throws IOException; Review Comment: Good idea, change it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
