pvary commented on code in PR #16575:
URL: https://github.com/apache/iceberg/pull/16575#discussion_r3334873311
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -1662,6 +1566,65 @@ void
testReadFileWithoutFieldIdsUsingNameMapping(FileFormat fileFormat) throws I
assertEquals(icebergSchema, convertToEngineRecords(genericRecords,
icebergSchema), readRecords);
}
+ @ParameterizedTest
+ @FieldSource("FILE_FORMATS")
+ void testDataWriterOverwrite(FileFormat fileFormat) throws IOException {
Review Comment:
Do we have a failure test when non-overwrite is used and the file is already
there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
