nazq commented on PR #2563:
URL: https://github.com/apache/iceberg-rust/pull/2563#issuecomment-4612613423
Hey @TwinklerG, PR'ed the first batch as TwinklerG/iceberg-rust#1 against
#2451's branch. Three of the #[ignore = "not yet implemented"] stubs now have
real test bodies and pass against tests
- add_required_column_without_default
- add_required_column_with_default
- add_required_column_with_update_column_default
~6 more of the ignored tests look doable against the current implementation
without needing new features (add_nested_list_of_structs, the
*_preserves_other_metadata family, delete_fields). The remaining ~6 are the
case-insensitive variants, which depend on a flag schema_update doesn't yet
thread through name resolution — that's a real implementation contribution, not
just a test.
I have some free time later this afternoon so drop a comment if this
direction looks sound.
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
