TwinklerG commented on PR #2563: URL: https://github.com/apache/iceberg-rust/pull/2563#issuecomment-4613782449
> Hey @TwinklerG, PR'ed the first batch as [TwinklerG#1](https://github.com/TwinklerG/iceberg-rust/pull/1) against #2451's branch. Three of the #[ignore = "not yet implemented"] stubs now have real test bodies and pass against testsHey , 已将第一批 PR 提交至 [TwinklerG#1](https://github.com/TwinklerG/iceberg-rust/pull/1) 的分支，针对 #2451 的分支。三个 #[ignore = "尚未实现"] 的占位符现在有了实际的测试代码，并且通过了测试 > > * add_required_column_without_default > * add_required_column_with_default添加带默认值的必需列 > * add_required_column_with_update_column_default添加带更新列默认值的必需列 > > ~6 more of the ignored tests look doable against the current implementation without needing new features (add_nested_list_of_structs, the *_preserves_other_metadata family, delete_fields). The remaining ~6 are the case-insensitive variants, which depend on a flag schema_update doesn't yet thread through name resolution — that's a real implementation contribution, not just a test.~6 更多被忽略的测试看起来可以在当前实现中完成，而无需新功能（add_nested_list_of_structs、*_preserves_other_metadata 系列、delete_fields）。剩下的 ~6 是不区分大小写的变体，这取决于一个标志，而 schema_update 目前还没有通过名称解析传递该标志——这是一个真正的实现贡献，而不仅仅是测试。 > > I have some free time later this afternoon so drop a comment if this direction looks sound.我今天下午有些空闲时间，如果这个方向看起来可行，请留言。 > > Cheers 干杯 Thanks @nazq for the contribution. I will review it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
