C-Loftus commented on issue #1096: URL: https://github.com/apache/iceberg-go/issues/1096#issuecomment-4614400214
> Given the rename problem, I'd suggest splitting this into two PRs: first the pure io.IO plumbing (read path, listing, stat) keeping local-fs as the only supported writer, then a separate change that introduces backend-specific commit primitives. That way the abstraction lands cleanly and the harder correctness work doesn't block it. Agreed that makes sense to me. I will begin with just the `io.IO` interface refactor logic and perhaps a subtask can be created to track the atomic correctness logic for a follow up PR. > Worth deciding up front whether you extend io.IO or compose interfaces. I think I would compose the interfaces so as to not disrupt other parts of the codebase. > Relative paths are a separate concern. Switching to io.IO is necessary but not sufficient for relative-path support — that's a contract decision about how the IO resolves identifiers, not catalog-side code. I'd suggest keeping the cloud-IO change pure and tracking relative-path support as a follow-up. Also agreed on this. I would think about this as a separate follow up, perhaps a bit down the line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
