tanmayrauth opened a new pull request, #1159: URL: https://github.com/apache/iceberg-go/pull/1159
`getArrowValueAsIcebergLiteral` previously assumed every `*array.Time64` already held microseconds and ignored the Arrow `Time64Type.Unit`. This is unreachable today because the schema-conversion path in `arrow_utils.go` only accepts `time64[us]`, but the helper was still silently producing wrong partition keys if `time64[ns]` ever reached it. Inspect `Time64Type.Unit` and return `iceberg.ErrInvalidSchema` for any unit other than microseconds, mirroring the schema-conversion error. Add a focused unit test covering both the success and rejection paths. Closes https://github.com/apache/iceberg-go/issues/1115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
