C-Loftus opened a new pull request, #1158: URL: https://github.com/apache/iceberg-go/pull/1158
First step of addressing https://github.com/apache/iceberg-go/issues/1096 This just changes the hadoop catalog implementation to support an interface but still requires a local filesystem. - All `os.` calls have been swapped to using an interface `HadoopCatalogFS`. - `HadoopCatalogFS` implements the same exact calls as `os.` - There were a few calls to `os.remove` that didn't handle the `err` value. I made these `_` to explicitly discard the err value. - In a follow up PR I can condense the number of methods to reduce interface size. However as a first pass, I wanted to keep the interface and thus the behavior very easy to review. - The `localfs` struct was extended to support the additional methods. - There were a few places where `mkdir` used `0o777` for a permission. I didn't see any reason to allow for execution by other users so I changed these to `0o755` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
