stark256-spec commented on PR #3454: URL: https://github.com/apache/iceberg-python/pull/3454#issuecomment-4617030399
Fixed the two ruff errors (`import pytest` unused, bare `f"tok1"` f-string) and added the performance tests you asked about: - `test_len_single_page_makes_no_extra_fetches`: asserts the fetch callback is never called when all results are in the first page - `test_len_multi_page_fetches_all_pages_once`: asserts pages 2 and 3 are each fetched exactly once, and a second `len()` call hits the cache with 0 additional fetches The `len()` cost for a single-page list is identical to a plain `list` — zero network calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
