stark256-spec commented on PR #3454: URL: https://github.com/apache/iceberg-python/pull/3454#issuecomment-4619208635
Thanks for the coordination note. Happy to defer to the maintainers on which approach lands. To summarise the trade-off for the review: **#3416 (iterator semantics):** Changes return types to `Iterator[Identifier]` across all catalog implementations. Clean interface but is a breaking change — callers using `len()`, slicing, `in`, or converting to list implicitly will need updates. **#3454 (PaginationList):** Keeps `list[Identifier]` return type (backward compatible). Subclasses `list` so all existing callers work unchanged. Lazy fetching happens transparently during iteration. If maintainers prefer the iterator direction from #3416, I'm happy to close this PR. If PaginationList's backward-compatibility is valued, I can rebase onto whatever #3416 lands on and focus only on the REST pagination piece. Whatever the decision, closing is fine — the important thing is that #3365 gets resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
