pvary commented on code in PR #15996: URL: https://github.com/apache/iceberg/pull/15996#discussion_r3355474633
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DVPosition.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.io.Serializable; +import org.apache.flink.annotation.Internal; + +/** + * A deletion vector position emitted by {@link EqualityConvertWorker} when resolving an equality + * delete. Identifies a specific row (by file path and position) to be marked as deleted, and + * carries the data file's {@code specId} + encoded partition so the downstream resolver can write + * the DV without re-reading data manifests. + * + * <p>{@code partition} is a {@code byte[]} (see {@link StructLikeSerializer#encodePartition}) so + * Flink serializes it natively rather than falling back to Kryo, including in the worker's keyed + * state. + */ +@Internal +public record DVPosition(String dataFilePath, long position, int specId, byte[] partition) Review Comment: I haven't realized that byte[] partition is needed. That's a bit concerning given the the number of DVPositions could be high. I need to think about this. What are your thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
