mxm commented on code in PR #15996: URL: https://github.com/apache/iceberg/pull/15996#discussion_r3357704241
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertPlanResult.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.io.Serializable; +import java.util.List; +import org.apache.flink.annotation.Internal; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; + +/** + * Result of equality convert planning. Produced by {@link EqualityConvertPlanner} and consumed by + * both {@link EqualityConvertDVResolver} (for partition info and DV merge gating) and {@link + * EqualityConvertCommitter} (for data files and staging deletes to commit). + * + * <p>A no-op cycle is encoded by {@link #stagingSnapshotId()} == {@link + * #NO_OP_STAGING_SNAPSHOT_ID}. Use {@link #noOp(Long, long, long)} to construct one and {@link + * #noOp()} to check. + * + * @param dataFiles new staging data files committed in the cycle + * @param stagingDVFiles staging DVs passed through to main, used by DVResolver to merge with + * newly-created DVs + * @param stagingSnapshotId staging snapshot the cycle resolved against, or {@link + * #NO_OP_STAGING_SNAPSHOT_ID} for a no-op cycle + * @param mainSnapshotId main branch snapshot ID the index was resolved against, used for commit + * validation + * @param triggerTimestamp original trigger timestamp, forwarded by the Committer to the Aggregator + * @param doneTimestamp timestamp after which all phase watermarks have been emitted; the DVResolver + * should only process the result when the watermark reaches or exceeds this value + */ +@Internal +public record EqualityConvertPlanResult( Review Comment: Yes, that makes sense 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
