xixipi-lining opened a new pull request, #1167: URL: https://github.com/apache/iceberg-go/pull/1167
**What changes were proposed in this pull request?** This PR fixes an authentication issue when updating tables. Currently, `internal.UpdateAndStageTable` and `internal.WriteMetadata` only use table properties. This causes IO failures for remote storage (like S3) because catalog-level credentials (e.g., `s3.access-key-id`) are lost. **Fix:** - Updated `UpdateAndStageTable` to accept `catprops` and merge it with table properties before initializing the filesystem. - Applied the same property merge to `internal.WriteMetadata`. - Note: This aligns the update logic with how `CreateStagedTable` already works. `nsprops` is intentionally omitted here since table locations are already fixed during updates. **How was this patch tested?** - `make test` passes successfully. - *No specific unit test was added for this fix, as our mock filesystems do not validate remote credentials, making it hard to test credential merging effectively. Relying on alignment with `CreateStagedTable` instead.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
