xixipi-lining commented on PR #1167: URL: https://github.com/apache/iceberg-go/pull/1167#issuecomment-4646065287
Thanks for the feedback and for catching the maps.Copy(nil) latent issue! I looked into passing catprops to WriteMetadata as you suggested, and realized we could actually go one step further. Since CreateStagedTable and UpdateAndStageTable already embed the fully merged IO properties inside the created Table 's filesystem closure, we can just pass the underlying *table.Table directly to WriteMetadata . This avoids coupling WriteMetadata to raw properties or even StagedTable explicitly. It completely removed the filesystem boilerplate code in both CreateTable and CommitTable across all catalogs (Glue, Hive, SQL). I've also added the nil-map protection in utils.go . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
