rambleraptor commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3365367323
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/InternalRowConverter.java:
##########
@@ -79,7 +79,8 @@ private static Object convert(Type type, Object value) {
: ChronoUnit.MICROS.between(EPOCH, ((LocalDateTime)
value).atZone(ZoneId.of("UTC")));
case STRING -> UTF8String.fromString((String) value);
case UUID -> UTF8String.fromString(value.toString());
- case FIXED, BINARY -> {
+ case FIXED -> (byte[]) value;
+ case BINARY -> {
Review Comment:
Ack. I'll leave this as a TODO and disable the FIXED tests for Spark (since
those are the problematic ones)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
