pvary commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3362159279
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -130,6 +133,56 @@ protected boolean supportsBatchReads() {
@TempDir private File tableDir;
+ /**
+ * Returns the schema with columns whose types are unsupported by this
engine removed. The base
+ * implementation accepts every column; engines that cannot handle certain
types override this
+ * method, typically by calling {@link #excludeColumnsContaining(Schema,
Set)}.
+ */
+ protected Schema filterUnsupported(Schema schema) {
Review Comment:
What if we only expose `unsupportedTypeIds`, like this:
```
protected Collection<Type.TypeID> unsupportedTypeIds() {
return Set.of();
}
```
Everything else could remain private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
