anoopj commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3366535818
##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -433,6 +453,81 @@ void testExistingToTerminalTransitions() {
assertThat(replaced.snapshotId()).isEqualTo(999L);
}
+ private static Stream<Arguments> deriveStatusCases() {
+ long sameSnapshot = 42L;
+ long laterSnapshot = 999L;
+ return Stream.of(
+ // ADDED source
+ Arguments.of(EntryStatus.ADDED, sameSnapshot, false,
EntryStatus.ADDED),
+ Arguments.of(EntryStatus.ADDED, sameSnapshot, true, EntryStatus.ADDED),
+ Arguments.of(EntryStatus.ADDED, laterSnapshot, false,
EntryStatus.EXISTING),
+ Arguments.of(EntryStatus.ADDED, laterSnapshot, true,
EntryStatus.MODIFIED),
+ // EXISTING source
+ Arguments.of(EntryStatus.EXISTING, sameSnapshot, false,
EntryStatus.EXISTING),
+ Arguments.of(EntryStatus.EXISTING, sameSnapshot, true,
EntryStatus.MODIFIED),
Review Comment:
You're correct. I have reverted this parameterized test addition as part of
the refactor revert Ryan requested. Replaced it with targeted tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
