stevenzwu commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3366561226
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +145,13 @@ Tracking build() {
replacedPositions);
}
+ private void promoteToModified() {
+ if (status == EntryStatus.EXISTING) {
+ this.status = EntryStatus.MODIFIED;
+ this.snapshotId = newSnapshotId;
+ }
+ }
Review Comment:
The new state-machine reads cleanly, but the rule that fresh-add builders
stay `ADDED` through `dvUpdated()` is implicit — a reader has to notice that
this method only flips `EXISTING`, then trace back to the no-source constructor
to see that `ADDED` is the starting state. A one-line javadoc captures the
intent in one place.
```suggestion
/**
* Promotes an EXISTING entry to MODIFIED on mutation. Fresh-add builders
(status = ADDED) are
* preserved — covers the same-commit append + DV attach case without a
special branch.
*/
private void promoteToModified() {
if (status == EntryStatus.EXISTING) {
this.status = EntryStatus.MODIFIED;
this.snapshotId = newSnapshotId;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
