nastra commented on code in PR #16439:
URL: https://github.com/apache/iceberg/pull/16439#discussion_r3371836716
##########
core/src/main/java/org/apache/iceberg/StatsUtil.java:
##########
@@ -171,14 +171,14 @@ public Types.NestedField struct(Types.StructType struct,
List<Types.NestedField>
@Override
public Types.NestedField field(Types.NestedField field, Types.NestedField
fieldResult) {
- if (field.type().isNestedType() || field.type().isVariantType()) {
+ if (field.type().isNestedType()) {
return null;
}
int fieldId = StatsUtil.statsFieldIdForField(field.fieldId());
if (fieldId >= 0) {
Types.StructType structType = FieldStatistic.fieldStatsFor(field,
fieldId);
- return optional(fieldId, Integer.toString(field.fieldId()),
structType);
+ return optional(fieldId, field.name(), structType);
Review Comment:
thanks for pointing that out. I pushed a fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
