smaheshwar-pltr commented on code in PR #2604:
URL: https://github.com/apache/iceberg-rust/pull/2604#discussion_r3375270481
##########
crates/integrations/datafusion/src/physical_plan/write.rs:
##########
@@ -244,8 +244,8 @@ impl ExecutionPlan for IcebergWriteExec {
let file_io = self.table.file_io().clone();
// todo location_gen and file_name_gen should be configurable
- let location_generator =
DefaultLocationGenerator::new(self.table.metadata().clone())
- .map_err(to_datafusion_error)?;
+ let location_generator =
+
DefaultLocationGenerator::new(self.table.metadata()).map_err(to_datafusion_error)?;
Review Comment:
Datafusion writes no longer need to clone the whole metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
