smaheshwar-pltr commented on code in PR #2604:
URL: https://github.com/apache/iceberg-rust/pull/2604#discussion_r3375277867
##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -54,7 +54,7 @@ pub struct DefaultLocationGenerator {
impl DefaultLocationGenerator {
/// Create a new `DefaultLocationGenerator`.
- pub fn new(table_metadata: TableMetadata) -> Result<Self> {
+ pub fn new(table_metadata: &TableMetadata) -> Result<Self> {
Review Comment:
Pointing out that this is a break - also updated
`crates/iceberg/src/writer/mod.rs` to reflect this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
