rdblue commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3376708230
##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -143,6 +145,17 @@ Tracking build() {
replacedPositions);
}
+ /**
+ * Promotes an EXISTING entry to MODIFIED on mutation. Fresh-add builders
(status = ADDED) are
+ * preserved — covers the same-commit append + DV attach case without a
special branch.
+ */
+ private void promoteToModified() {
+ if (status == EntryStatus.EXISTING) {
Review Comment:
> if the status is ADDED (the same-commit append + DV attach case), we want
to keep the status as ADDED.
Yes, my point is really that this is dividing the logic of how status
evolves across multiple places and the only benefit is not copying one line of
code? I don't think this method is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
