anoopj commented on code in PR #16689:
URL: https://github.com/apache/iceberg/pull/16689#discussion_r3381935271
##########
core/src/test/java/org/apache/iceberg/TestTrackingStruct.java:
##########
@@ -106,19 +106,13 @@ void testAllStatuses(EntryStatus status) {
@Test
void testIsLive() {
- TrackingStruct tracking = new TrackingStruct(Tracking.schema());
-
- tracking.set(STATUS_ORDINAL, EntryStatus.ADDED.id());
- assertThat(tracking.isLive()).isTrue();
-
- tracking.set(STATUS_ORDINAL, EntryStatus.EXISTING.id());
- assertThat(tracking.isLive()).isTrue();
-
- tracking.set(STATUS_ORDINAL, EntryStatus.DELETED.id());
- assertThat(tracking.isLive()).isFalse();
+ Tracking source = sourceTracking();
- tracking.set(STATUS_ORDINAL, EntryStatus.REPLACED.id());
- assertThat(tracking.isLive()).isFalse();
+ assertThat(TrackingBuilder.added(42L).build().isLive()).isTrue();
+ assertThat(TrackingBuilder.from(source, 999L).build().isLive()).isTrue();
+ assertThat(TrackingBuilder.from(source,
999L).dvUpdated().build().isLive()).isTrue();
Review Comment:
Removed the test after I moved `isLive` to enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
