happydave1 commented on PR #1138: URL: https://github.com/apache/iceberg-go/pull/1138#issuecomment-4658123095
Thank you @paleolimbot and @zeroshade for reviewing. I believe I have addressed each comment by: 1) updating `icebergCRSToGeoArrowMetadata` to handle the default CRS case (`"OGC:CRS84"`) as expected. 2) updating `icebergCRSToGeoArrowMetadata` to handle case `"srid:0"` 3) erroring out the `projjson` case in both `icebergCRSToGeoArrowMetadata` and `geoArrowCRSToIcebergCRS` - this can be addressed in a separate PR 4) updating `TestIcebergGeoTypesToArrowSchema` to mirror tests found in https://github.com/apache/arrow-rs/pull/10065 5) mapping geoarrow crs of `"OGC:CRS84"` and `"EPSG:4326"` to the default CRS `"OGC:CRS84"` so that `iceberg.GeographyTypeOf` and `iceberg.GeometryTypeOf` both create geo types with omitted (`""`) crs. I would appreciate a second pass whenever you guys have a chance, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
