happydave1 commented on PR #1138:
URL: https://github.com/apache/iceberg-go/pull/1138#issuecomment-4674786396
Hi @laskoviymishka @paleolimbot, thank you guys for giving my PR a second
look. I appreciate the comments!
I believe I have addressed all comments but feel free to correct me if I
missed anything!
1) Regarding `EPSG:4326` behavior, I have added a round trip test
specifically for this CRS, pinning its behavior. I have collapsed the write
behavior for `EPSG:4326` so that it behaves consistently across reads and
writes.
2) Added read side (arrow field to Iceberg type) tests ensuring that partial
projjson CRS's
- `"crs": "EPSG:4326"` and `"crs": "OGC:CRS84"` (case insensitive)
- `"crs": {..., "id":{"authority": "OGC", "code": "CRS84"}`
- `"crs": {..., "id":{"authority": "EPSG", "code": 4326}`
- `"crs": {..., "id":{"authority": "EPSG", "code": "4326"}`
all map to default Iceberg CRS.
3) Added a test confirming that the `projjson` write case cleanly errors
from the public entrypoint (`table.TypeToArrowType`)
4) Added read side `projjson` support, write side cleanly errors.
5) Updated error wrapping to use `%w` instead of `%v`
6) Added an error case for `wkt2:2019` on the read side. Also added a test
which pins this behavior. Note that this relies on `crs_type` being set to
`"wkt2:2019"`. In the case that `crs_type` is not set, the write path will go
through a length check which it will likely fail since `wkt2:2019` crs type is
quite verbose. We can work on supporting the `crs_type` not set path in a
future PR.
7) Added `"crs_type": "authority_code"` for crs with `AUTHORITY:CODE` form.
8) Added `//nolint:errcheck` for discarded JSON marshalling errors involving
strings.
9) Added a test case for a geoarrow metadata with only `"crs_type"` set.
10) Documented best effort edge hint.
11) Hoisted `strings.ToLower(crs) in write case and used `strings.EqualFold`
to check equality in read case. Added tests to guard this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
