rahulsmahadev commented on PR #3418: URL: https://github.com/apache/iceberg-python/pull/3418#issuecomment-4685448463
Pushed 47a5382 addressing the four review nits: - Dropped the misleading "when none are set" sentence from the docs. - Initialized `retries` and `backoff_factor` to 0 so the `Retry(...)` call no longer needs inline conditional defaults. A `Retry(total=0)` is a no-op. - Extracted the loopback HTTP server scaffold from the retry test into a `_local_rest_server_503_then_200` context manager; the test body is now just the catalog construction + assertions. Thanks again for the careful review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
