wombatu-kun commented on code in PR #16713:
URL: https://github.com/apache/iceberg/pull/16713#discussion_r3385811600
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -233,6 +234,11 @@ public WriteBuilder setAll(Map<String, String> properties)
{
return this;
}
+ public WriteBuilder withDictionaryEncoding(String columnPath, boolean
enabled) {
Review Comment:
The columnPath argument becomes a key in colNameToParquetPathMap, whose keys
are Iceberg column names (schema.findColumnName), not Parquet paths (the file
calls those parquetColumnPath). For list/map children the two diverge - Iceberg
tags.element vs Parquet tags.list.element, or m.key vs m.key_value.key - so
passing a Parquet path here misses the lookup and is dropped with a LOG.warn
instead of applied. Renaming the parameter to columnName would match
colNameToParquetPathMap and avoid the clash with parquetColumnPath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
