kamcheungting-db opened a new pull request, #722:
URL: https://github.com/apache/iceberg-cpp/pull/722
## What
First of PR that adds a logging system to iceberg-cpp.
This PR adds LogLevel — the severity scale every later piece builds on — and
nothing else.
- enum class LogLevel { kTrace, kDebug, kInfo, kWarn, kError, kCritical,
kFatal, kOff }, ordered most-to-least verbose so "should this log?" is a plain
level >= threshold check. kOff is the max sentinel for disabling logging.
- constexpr ToString(LogLevel) and a case-insensitive LogLevelFromString
returning Result<LogLevel> — same idiom as CounterUnit in metrics/counter.h.
Header-only: this PR adds src/iceberg/logging/log_level.h, wires the new
src/iceberg/logging/ directory into CMake, and adds log_level_test.cc
(ToString/FromString round-trip, case-insensitivity, unknown-input error,
ordering).
## Why
iceberg-cpp has no logging today — only error-as-value Result. This stack
introduces a pluggable logger; levels are the foundational vocabulary, landed
on their own so the
rest reviews cleanly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
