sungwy commented on PR #15850: URL: https://github.com/apache/iceberg/pull/15850#issuecomment-4672944641
Hi @adutra - I took another pass through this, and my approval stands - but as an approval of the normative language describing the behavior of the `signer.properties.*`. Thinking about it a bit more, because there are already active PRs depending on this spec change to begin forwarding properties in the client, this feels closer to a behavior-change proposal than a doc clarification. Procedurally, I think that warrants a community `VOTE` per our [contribution guide](https://iceberg.apache.org/contribute/?h=contribut#merging-pull-requests) before we can merge it in. In parallel, I just responded to your [mailing list thread](https://lists.apache.org/thread/wv64wgq9n9ydk0pblwphcjjz528vjx72) about adding a structure to encapsulate these signing properties. What do you think about the idea of introducing that structure in incremental steps? If you're open to it, I really think pairing that approach with the deprecation notice for these top-level signer properties would be a great way to build quick community consensus and get this moving forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
