singhpk234 commented on code in PR #16768:
URL: https://github.com/apache/iceberg/pull/16768#discussion_r3410088251
##########
core/src/main/java/org/apache/iceberg/rest/ScanTaskIterable.java:
##########
@@ -107,7 +107,18 @@ public CloseableIterator<FileScanTask> iterator() {
}
@Override
- public void close() throws IOException {}
Review Comment:
lets then just add the iterator in the closableGroup like we don in
ParallelIterable
https://github.com/apache/iceberg/blob/ce4d7d8973cbe57306ef4927fbafa6ca53b5982c/core/src/main/java/org/apache/iceberg/util/ParallelIterable.java#L77
and call close of the iterator when the iterable is closed instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
