danielcweeks commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r544515999
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -85,5 +101,6 @@ private S3Client client() {
@Override
public void initialize(Map<String, String> properties) {
Review comment:
As I mention above, in the `FileIO` comment, having both this path and
constructor path for initialization causes some problems. ~~If we use the
default constructor, then `initialize()` gets called, don't we end up with two
S3 client being created (and the first never gets properly closed)?~~ I forgot
this is a supplier, so it doesn't actually get created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
