goel-skd opened a new pull request, #748:
URL: https://github.com/apache/iceberg-cpp/pull/748
fix: cast to unsigned char in ASCII case conversion
`std::tolower`/`toupper` are UB when passed a negative `char`, which is what
you get for any non-ASCII byte in a signed `char`. `StringUtils::ToLower`,
`ToUpper`, and `EqualsIgnoreCase`
all did this. Cast through `unsigned char`.
Behavior for ASCII is unchanged; this doesn't add Unicode case folding,
just fixes the UB.
Related: #613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
