goel-skd commented on PR #748: URL: https://github.com/apache/iceberg-cpp/pull/748#issuecomment-4724684913
@wgtmac - the locale dependency was in the original code too. This PR doesn't introduce or worsen it. Fixing UB is the only intention with this PR. But I will include copilot's suggestion to tighten up things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
