badalprasadsingh commented on code in PR #1211:
URL: https://github.com/apache/iceberg-go/pull/1211#discussion_r3428029646
##########
catalog/sql/sql.go:
##########
@@ -92,7 +92,7 @@ func init() {
}
}()
- return NewCatalog(p.Get(name, "sql"), sqldb,
SupportedDialect(dialect), p)
+ return NewCatalog(name, sqldb, SupportedDialect(dialect), p)
Review Comment:
1. Added the migration UPDATEs in the PR body's **Changelog Note** section
since the repo doesn't keep a `CHANGELOG.md`.
2. Added a two-line comment at the call site noting that `name` is the
`catalog_name` partition key persisted in `iceberg_tables` /
`iceberg_namespace_properties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
