badalprasadsingh commented on PR #1211: URL: https://github.com/apache/iceberg-go/pull/1211#issuecomment-4730059384
@laskoviymishka, both addressed: 1. **Changelog**: Since, iceberg-go doesn't maintain a `CHANGELOG.md`, I've added a **Changelog Note** section to the PR body with the breaking change callout and the re-key `UPDATE`s for both `iceberg_tables` and `iceberg_namespace_properties`. 2. **Test**: Done - second catalog loaded as `sql` against the same DB asserts `NotContains` on the namespace created under `"test_catalog"`. Verified it locally: that the new assertion fails on the pre-fix code and passes after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
