WZhuo commented on PR #721: URL: https://github.com/apache/iceberg-cpp/pull/721#issuecomment-4737271346
One suggestion: in `RowDelta::ValidateNoConfirmedFileAndPositionDeletes()`, the `conflicting_files` vector could use `std::vector<std::string_view>` instead of `std::vector<std::string>` to avoid unnecessary string copies. ```cpp std::vector<std::string_view> conflicting_files; ``` This is safe because: - `file->file_path` is a `std::string` member of `DataFile` - `removed_data_files_` holds `shared_ptr<DataFile>`, so the backing strings live through the function - `conflicting_files` is a local only consumed by `FormatRange` before returning — the `string_view`s never escape the scope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
