huan233usc commented on PR #16765:
URL: https://github.com/apache/iceberg/pull/16765#issuecomment-4738603935
Thanks for calling this out. I changed this in `523d47863` to preserve
explicitly supplied default CRS / edge algorithm in Iceberg type string
serialization, while keeping `equals` / `hashCode` based on resolved defaults
so explicit defaults and omitted defaults remain semantically equal.
So examples now behave as:
- `GeometryType.crs84()` -> `geometry`
- `GeometryType.of("OGC:CRS84")` -> `geometry(OGC:CRS84)`
- `GeographyType.crs84()` -> `geography`
- `GeographyType.of("OGC:CRS84", SPHERICAL)` -> `geography(OGC:CRS84,
spherical)`
This avoids relying on future/default interpretation to recover an
explicitly written default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
