huan233usc commented on PR #16765: URL: https://github.com/apache/iceberg/pull/16765#issuecomment-4795498677
Thanks @szehon-ho! Applied both suggestions in 943240599 — `GeometryType.toString()` now formats from `crs()` and `GeographyType.toString()` from `crs()` / `algorithm()`, so `toString()` stays consistent with `equals`/`hashCode` and emits canonical CRS casing. The divergence you flagged (`geometry(ogc:crs84)` was `.equals()` to `crs84()` but serialized non-canonically) is fixed, and since `SchemaParser` writes `toString()` into metadata, the canonical form is now what gets persisted. Added assertions in `testGeospatialTypeToString` covering the casing case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
