nastra commented on code in PR #16861:
URL: https://github.com/apache/iceberg/pull/16861#discussion_r3442831638
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -1077,4 +1079,11 @@ private Catalog.TableBuilder newBuilder(Identifier
ident, Schema schema) {
public Catalog icebergCatalog() {
return icebergCatalog;
}
+
+ @Override
+ public void close() throws IOException {
Review Comment:
I think we're prematurely fixing this here without having it fixed in Spark
first. If we ship this code e.g. before it lands in Spark, then people will
assume that the catalog is always being closed, which isn't necessarily the
case. I'm curious to hear what other maintainers think about this.
/cc @RussellSpitzer @singhpk234 @huaxingao @amogh-jahagirdar @pvary
That being said, I don't have any strong objections making SparkCatalog
closeable, but I don't think it buys us anything without having a fix in Spark
itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
