pvary commented on code in PR #16861:
URL: https://github.com/apache/iceberg/pull/16861#discussion_r3461041385


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -1077,4 +1079,11 @@ private Catalog.TableBuilder newBuilder(Identifier 
ident, Schema schema) {
   public Catalog icebergCatalog() {
     return icebergCatalog;
   }
+
+  @Override
+  public void close() throws IOException {

Review Comment:
   For a long time, we have intentionally ensured that catalogs are not closed. 
This question keeps coming up, which suggests that the current behavior is not 
what users naturally expect.
   If we want to change that behavior, I think it would warrant a discussion on 
the dev list first.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to