mbutrovich commented on PR #15470: URL: https://github.com/apache/iceberg/pull/15470#issuecomment-4770539258
Thanks for the detailed pass, @amogh-jahagirdar and @kevinjqliu. Sorry for the delayed response, I was on vacation for a few days. I reworked the PR per the latest feedback. API is now additive plus deprecation (9-param `rewriteDeleteManifest` and the void `rewritePositionDeleteFile` deprecated for 1.12.0/1.13.0; new public `rewritePositionDelete`), so `./gradlew revapi` is clean. Fixed the DV-sharing-one-Puffin collision by deduping the physical rewrite on `location()` while keeping the logical delete-file count via `DeleteFileSet.of`. Added regression tests for the DV case and the DELETED-entry size fallback, and ported all the new tests across Spark 3.5 / 4.0 / 4.1. One note: the DV test is pinned to v3 because on v4 the test setup hits a parquet-manifest read path the harness does not support, which looks like a separate v4 gap unrelated to this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
