mbutrovich commented on code in PR #15470:
URL: https://github.com/apache/iceberg/pull/15470#discussion_r3453863750
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java:
##########
@@ -310,21 +317,29 @@ private Result rebuildMetadata() {
// rebuild manifest files
Set<ManifestFile> metaFiles = rewriteManifestListResult.toRewrite();
- RewriteContentFileResult rewriteManifestResult =
- rewriteManifests(deltaSnapshots, endMetadata, metaFiles);
- // rebuild position delete files
- Set<DeleteFile> deleteFiles =
- rewriteManifestResult.toRewrite().stream()
- .filter(e -> e instanceof DeleteFile)
- .map(e -> (DeleteFile) e)
- .collect(Collectors.toCollection(DeleteFileSet::create));
- rewritePositionDeletes(deleteFiles);
+ // Enumerate the distinct position delete files referenced by the delete
manifests being
+ // rewritten (metadata-only pass).
Review Comment:
Done, removed/trimmed.
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
Review Comment:
We've gone in circles a bit with earlier feedback about API changes. I'll
see if I reconcile your suggestions with the feedback received previously.
Thank you for all of the comments, @amogh-jahagirdar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
