raghav-reglobe commented on PR #16363: URL: https://github.com/apache/iceberg/pull/16363#issuecomment-4775265082
Good catch on the issue number — you're right, PARQUET-2326 is the jcommander bump. The adaptive bloom filter feature is PARQUET-2254 (apache/parquet-java#1042, which added `AdaptiveBlockSplitBloomFilter`). Fixed that across the code, the PR title, and the description. The rest of the review is in there too: renamed the field/accessor to `adaptiveBloomFilterEnabled`, noted in the javadoc that it pairs with `PARQUET_BLOOM_FILTER_MAX_BYTES`, documented the property in `configuration.md`, and dropped the `test` prefixes on the new tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
