pan3793 commented on issue #1951: URL: https://github.com/apache/iceberg/issues/1951#issuecomment-748210178
@stevenzwu I think we have a different understanding of `Shim`, what I mean is some like: https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala , so there is no need to maintain each version in a separate module. And I think the situation of `flink-kafka-connector` is quite different. Firstly, kafka provide a light `kafka-clients` to communicate with broker via RPC protocol, and since 0.10, kafka guarantees that the client is compatible with lower versions of broker, so after drop support kafka 0.9 and before versions, there is only one universal kafka connector with latest `kafka-clients`. > Since the Flink Iceberg connector lives in the Iceberg project. The module uses some Flink @Internal API which not guarantee compatible in each minor release, i.e. `RowDataTypeInfo` is renamed into `InternalTypeInfo` from flink 1.11 to flink 1.12, so I think the most light way is introduce a `FlinkShim` and use reflection to invoke the specific `method` in specific flink version. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
