laskoviymishka opened a new issue, #1276: URL: https://github.com/apache/iceberg-go/issues/1276
Follow-up to #916. `walkDirectory` first tries `fsys.(iceio.ListableIO)` and returns immediately if it matches, then falls through to a `switch` with a `LocalFS` case and a blob `default` that calls `getBucketName`, which reaches into the FS with `reflect` to pull a `Bucket` field. Every concrete IO now implements `WalkDir` / `ListableIO` — `LocalFS`, `blobFileIO` (all gocloud constructors return it), and `MemFS` — so the `ListableIO` branch always wins and the switch plus `getBucketName` can never run. The thread asked to remove this once #917 landed; #917 is merged. Delete the post-`ListableIO` fallback and `getBucketName` from `walkDirectory`, return an error if a non-`ListableIO` ever shows up, and drop the now-unused `reflect` import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
