laskoviymishka opened a new issue, #1277: URL: https://github.com/apache/iceberg-go/issues/1277
Follow-up to #1062. `TestCreateAzureBucketManagedIdentityCredentialCalled` only asserts the error contains `"ManagedIdentityCredential"`. But `DefaultAzureCredential` includes `ManagedIdentityCredential` in its chain, and the chained error aggregates each source's message — so the DAC fallback error also contains that substring. If a regression made the managed-identity flag fall through to DAC, this test would still pass. At minimum add `assert.NotContains(t, err.Error(), "DefaultAzureCredential")`. Better, add a test seam — an injectable credential constructor on the bucket factory — so the test can assert the managed-identity constructor was actually called rather than substring-matching error text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
